user.Logout hinzugefügt zum cookie clearen, macht das ganze etwas schöner. vielleicht sollte der datenbankkram auch dort gemacht werden, aber dann bräuchten wir irgendwoher die sql.Conn.

1 files changed, 8 insertions, 13 deletions

diff --git a/charakterin.go b/charakterin.go
index 127e362..abf9627 100644
--- a/charakterin.go
+++ b/charakterin.go
@@ -119,7 +119,7 @@ func (c *Charakterin) Login(w http.ResponseWriter, r *http.Request) {
 
 // Logout loggt einen Charakter aus. Wird direkt über den Request gehandlet.
 func (c *Charakterin) Logout(w http.ResponseWriter, r *http.Request) {
-        cookie, err := r.Cookie("session")
+        user, err := c.GetUserFromRequest(r)
         if err != nil {
                 http.Redirect(w, r, c.FallbackRoute, 302)
                 return
@@ -127,30 +127,24 @@ func (c *Charakterin) Logout(w http.ResponseWriter, r *http.Request) {
         
         stmt, err := c.Database.Prepare("DELETE FROM login.sessions WHERE id=$1")
         if err != nil {
-                http.Redirect(w, r, c.FallbackRoute, 302)
+                http.Error(w, "500", http.StatusInternalServerError)
                 return
         }
         
-        result, err := stmt.Exec(cookie.Value)
+        result, err := stmt.Exec(user.SessionID)
         if err != nil {
                 log.Println(err)
-                http.Redirect(w, r, c.FallbackRoute, 302)
+                http.Error(w, "500", http.StatusInternalServerError)
                 return
         }
         
         if val, err := result.RowsAffected(); err != nil || val == 0 {
-                log.Println("could not remove session",cookie.Value,err)
+                log.Println("could not remove session",user.SessionID,err)
                 http.Redirect(w, r, c.FallbackRoute, 302)
                 return
         }
         
-        http.SetCookie(w, &http.Cookie{
-                Name: "session",
-                Value: "benis",
-                Expires: time.Now(),
-                MaxAge: 0,
-        })
-        
+        user.Logout(w)
         http.Redirect(w, r, c.FallbackRoute, 302)
 }
 
@@ -174,7 +168,7 @@ func (c *Charakterin) IsLoggedIn(r *http.Request) bool {
 func (c *Charakterin) GetUserFromRequest(r *http.Request) (*User, error) {
         cookie, err := r.Cookie("session")
         if err != nil {
-                return nil, errors.New("not logged in")
+                return nil, errors.New("no_session_cookie")
         }
 
         var email, name string
@@ -199,6 +193,7 @@ func (c *Charakterin) GetUserFromRequest(r *http.Request) (*User, error) {
                 password,
                 dspName,
                 lastActivity,
+                cookie.Value,
         }
 
         return user, nil